Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix modSecurity typo #3435

Merged
merged 4 commits into from Jul 25, 2022
Merged

docs: fix modSecurity typo #3435

merged 4 commits into from Jul 25, 2022

Conversation

michael12312
Copy link
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@michael12312 michael12312 requested a review from a team as a code owner May 26, 2022 05:05
@cla-checker-service
Copy link

cla-checker-service bot commented May 26, 2022 •
edited

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented May 26, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T05:03:47.729+0000

  • Duration: 15 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@michael12312
Copy link
Contributor Author

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

This will need to have changes in the changelog.yml and the manifest.yml.

@elasticmachine
Copy link

elasticmachine commented Jul 25, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.92
Classes 100.0% (3/3) 💚 2.92
Methods 100.0% (28/28) 💚 9.891
Lines 94.068% (222/236) 👍 2.132
Conditionals 100.0% (0/0) 💚

@michael12312
Copy link
Contributor Author

@efd6
hi, I updated changelog and manifest, please help to review, thanks!

@michael12312
Copy link
Contributor Author

/test

2 similar comments
@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

@michael12312 @efd6
feat: Update changelog.yml, type to bugfix
dff6ee5 
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@michael12312
Copy link
Contributor Author

/test

@michael12312 michael12312 requested a review from efd6 July 25, 2022 05:02
@efd6
Copy link
Contributor

efd6 commented Jul 25, 2022

/test

@michael12312
Copy link
Contributor Author

@efd6
all tests passed, can you merge the PR now?
Or if more changes needed, please let me know.

efd6
efd6 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 4b9333e into elastic:main Jul 25, 2022
@michael12312 michael12312 deleted the issue-2278 branch July 25, 2022 06:32
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michael12312 @elasticmachine @efd6