New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIS_2617: Migrating tile_map to map in dashboards #3438
Conversation
🌐 Coverage report
|
/test |
/test |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion changes LGTM.
I think this would be a good opportunity to "unlink" the visualizations such that they are embedded into the dashboard.
Andrew, since this issue involves multiple integrations. Would it be better if we track the unlinking the visualisations as part of separate issue for all of these integrations ? |
@andrewkroh @jsoriano @flash1293 : I am doing this migration using the latest stack 8.2. As per the issue the editor for tile map is removed in 8.0 and map was added. cc: @lalit-satapathy |
@ishleenk17 yes, it would be nice to build the dashboards with the oldest supported version if possible, so compatibility with more versions is maintained. Maybe this can be done with 7.x, tile_maps were removed in 8.0, but I think that the map objects were already available in previous versions. So maybe you can build them with 7.17 if you want to continue maintaining the same package for both majors. |
I agree with @jsoriano that it would be best to use a 7.17 so that we can maintain compatibility for users still on 7.x, but AFAIK the "View in Maps" button that converts the tile_map for you only exists in 8.0+. You can check if it exists in 7.17, and if not then it will need to drop the 7.x compatibility or find a different way to do the conversion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the "View in Maps" conversion action only exists in 8.x then I am good with these changes.
Yes, just checked. The view maps works for map objects from 8.0 stack. So, I am using that stack for the dashboards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
This PR replaces the tile_map object with map in IIS Logs dashboard
Checklist
changelog.yml
file.How to test this PR locally
Load the newly created dashboard and we should see map as the object
Screenshots
Below screenshot shows map object updated in IIS