Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS_2617: Migrating tile_map to map in dashboards #3438

Merged
merged 8 commits into from Jun 3, 2022

Conversation

ishleenk17
Copy link
Contributor

@ishleenk17 ishleenk17 commented May 26, 2022

  • Enhancement

What does this PR do?

This PR replaces the tile_map object with map in IIS Logs dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Load the newly created dashboard and we should see map as the object

Screenshots

Below screenshot shows map object updated in IIS

Screenshot 2022-05-26 at 1 46 12 PM

@ishleenk17 ishleenk17 requested a review from a team as a code owner May 26, 2022 10:50
@elasticmachine
Copy link

elasticmachine commented May 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T19:01:26.803+0000

  • Duration: 12 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.538
Classes 100.0% (2/2) 💚 3.538
Methods 85.714% (30/35) 👎 -2.996
Lines 91.398% (255/279) 👍 1.677
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 removed the request for review from andrewkroh May 26, 2022 11:16
@ishleenk17
Copy link
Contributor Author

/test

@ishleenk17 ishleenk17 marked this pull request as draft May 26, 2022 12:09
@ishleenk17
Copy link
Contributor Author

/test

@ishleenk17
Copy link
Contributor Author

/test

@ishleenk17 ishleenk17 marked this pull request as ready for review May 30, 2022 11:03
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion changes LGTM.

I think this would be a good opportunity to "unlink" the visualizations such that they are embedded into the dashboard.

packages/iis/changelog.yml Show resolved Hide resolved
@ishleenk17
Copy link
Contributor Author

ishleenk17 commented May 31, 2022

The conversion changes LGTM.

I think this would be a good opportunity to "unlink" the visualisations such that they are embedded into the dashboard.

Andrew, since this issue involves multiple integrations. Would it be better if we track the unlinking the visualisations as part of separate issue for all of these integrations ?

@ishleenk17
Copy link
Contributor Author

ishleenk17 commented Jun 1, 2022

@andrewkroh @jsoriano @flash1293 : I am doing this migration using the latest stack 8.2.
Hence we see the visualisations/dashboards/maps in 8.2. As a result of this we have to drop all the previous kibana versions supported (7.14 an 8.0).

As per the issue the editor for tile map is removed in 8.0 and map was added.
Shall we do the change with older 8.0 ELK stack ? In that case we would have to drop support for only 7.14.
Please share your inputs here ?

cc: @lalit-satapathy

@ishleenk17 ishleenk17 requested a review from flash1293 June 1, 2022 08:19
@jsoriano
Copy link
Member

jsoriano commented Jun 1, 2022

@ishleenk17 yes, it would be nice to build the dashboards with the oldest supported version if possible, so compatibility with more versions is maintained.

Maybe this can be done with 7.x, tile_maps were removed in 8.0, but I think that the map objects were already available in previous versions. So maybe you can build them with 7.17 if you want to continue maintaining the same package for both majors.

@andrewkroh
Copy link
Member

I am doing this migration using the latest stack 8.2.
Hence we see the visualisations/dashboards/maps in 8.2. As a result of this we have to drop all the previous kibana versions supported (7.14 an 8.0).

I agree with @jsoriano that it would be best to use a 7.17 so that we can maintain compatibility for users still on 7.x, but AFAIK the "View in Maps" button that converts the tile_map for you only exists in 8.0+. You can check if it exists in 7.17, and if not then it will need to drop the 7.x compatibility or find a different way to do the conversion.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the "View in Maps" conversion action only exists in 8.x then I am good with these changes.

@ishleenk17
Copy link
Contributor Author

I am doing this migration using the latest stack 8.2.
Hence we see the visualisations/dashboards/maps in 8.2. As a result of this we have to drop all the previous kibana versions supported (7.14 an 8.0).

I agree with @jsoriano that it would be best to use a 7.17 so that we can maintain compatibility for users still on 7.x, but AFAIK the "View in Maps" button that converts the tile_map for you only exists in 8.0+. You can check if it exists in 7.17, and if not then it will need to drop the 7.x compatibility or find a different way to do the conversion.

Yes, just checked. The view maps works for map objects from 8.0 stack. So, I am using that stack for the dashboards.
This will result in dropping support for 7.14, but still supporting ^8.0.0

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17 ishleenk17 merged commit 66710aa into elastic:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tile_map objects to map objects
5 participants