Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TLS parsing for multiple integrations #3440

Merged
merged 10 commits into from
Jun 15, 2022
Merged

Update TLS parsing for multiple integrations #3440

merged 10 commits into from
Jun 15, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented May 29, 2022 •
edited
Loading

What does this PR do?

Adds additional parsing for multiple tls.* fields.

  • Adds JA3/JA3S parsing & fixed not valid/before date fields in Zeek SSL log
  • Adds JA3/JA3S parsing for Carbon Black EDR
  • Add JA3/JA3S hash values to related.hash in Zeek SSL, Carbon Black, Fireeye NX, Suricata, Network Traffic integrations

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner May 29, 2022 02:12
@elasticmachine
Copy link

elasticmachine commented May 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-10T02:27:26.362+0000

  • Duration: 71 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 511
Skipped 0
Total 511

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 5, 2022

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Jun 5, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Jun 5, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (42/42) 💚
Files 96.512% (83/86) 👎 -0.048
Classes 96.512% (83/86) 👎 -0.048
Methods 86.391% (730/845) 👎 -2.518
Lines 93.01% (10272/11044) 👍 3.113
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor

efd6 commented Jun 6, 2022

network_traffic needs ecs.yml updated to include related.hash.

@efd6
Copy link
Contributor

efd6 commented Jun 6, 2022

Sorry, the version has changed under your feet.

@efd6
Copy link
Contributor

efd6 commented Jun 8, 2022

/test

@legoguy1000 @efd6
Fix change log
2853990 
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6
Copy link
Contributor

efd6 commented Jun 8, 2022

/test

@legoguy1000
Copy link
Contributor Author

@efd6 10th times the charm :(

@andrewkroh
Copy link
Member

/test

@legoguy1000 legoguy1000 requested a review from efd6 June 13, 2022 12:59
efd6
efd6 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thanks for hanging in there).

@legoguy1000
Copy link
Contributor Author

@efd6 Can we merge?

@efd6 efd6 merged commit 377c2c8 into elastic:main Jun 15, 2022
@legoguy1000 legoguy1000 deleted the ja3-parsing branch June 15, 2022 02:58
@andrewkroh andrewkroh mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legoguy1000 @elasticmachine @efd6 @andrewkroh