Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_dashboard_2617: Migrate tile map to map #3447

Merged
merged 8 commits into from Jun 3, 2022

Conversation

ishleenk17
Copy link
Contributor

@ishleenk17 ishleenk17 commented Jun 1, 2022

  • Enhancement

What does this PR do?

This PR replaces the tile_map object with map in NGINX Overview Dashboard and nginx_ingress_controller Logs overview dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Load the newly created dashboard and we should see map as the object

Screenshots

Below screenshot shows map object updated in NGINX

Screenshot 2022-06-01 at 1 19 00 AM

Below screenshot shows map object updated in nginx_ingress_controller

Screenshot 2022-06-01 at 1 05 47 PM

@ishleenk17 ishleenk17 requested a review from a team as a code owner June 1, 2022 05:59
@elasticmachine
Copy link

elasticmachine commented Jun 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T18:59:19.273+0000

  • Duration: 15 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 71
Skipped 0
Total 71

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 66.667% (4/6) 👎 -29.796
Classes 66.667% (4/6) 👎 -29.796
Methods 80.645% (50/62) 👎 -8.065
Lines 79.793% (462/579) 👎 -9.928
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 requested a review from a team as a code owner June 1, 2022 07:39
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishleenk17 ishleenk17 merged commit 3571a51 into elastic:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tile_map objects to map objects
4 participants