crowdstrike/fdr: Prevent ingesting documents without @timestamp
#3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
andrewkroh
reviewed
Jun 8, 2022
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
andrewkroh
reviewed
Jun 9, 2022
| "@timestamp": "2022-06-08T10:59:53.840983900Z", | ||
| "crowdstrike": { | ||
| "AgentLoadFlags": "0", | ||
| "AgentLocalTime": "2021-11-09T05:47:19.952Z", |
There was a problem hiding this comment.
Did you consider using AgentLocalTime?
I think Time could also be considered (probably before the _ingest.timestamp). That is supposed to be the timestamp of when the event was received by CrowdStrike cloud. (docs are hard to come by and I don't know what type of event this is, but I'm looking at this page)
There was a problem hiding this comment.
Thanks. For now I used AgentLocalTime. This covers all our samples.
In some cases, FDR documents can lack the `@timestamp` field due to missing timestamp source fields (`timestamp`/`CreationTimestamp`). This adds support for the `UTCTimestamp` field and also adds a last-chance processor to set `@timestamp` to the ingest timestamp in case all fields are missing.
andrewkroh
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some cases, FDR documents can lack the
@timestampfield due tomissing timestamp source fields (
timestamp/CreationTimestamp).This adds support for the
UTCTimestampfield and also adds alast-chance processor to set
@timestampto the ingest timestamp incase all fields are missing.
Checklist
changelog.ymlfile.