Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] mapping for rule id #3503

Merged
merged 7 commits into from Jun 14, 2022
Merged

[Cloud Posture] mapping for rule id #3503

merged 7 commits into from Jun 14, 2022

Conversation

CohenIdo
Copy link
Contributor

No description provided.

@elasticmachine
Copy link

elasticmachine commented Jun 13, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-14T12:39:55.564+0000

  • Duration: 14 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 13, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.432
Classes 100.0% (0/0) 💚 3.432
Methods 33.333% (1/3) 👎 -55.556
Lines 100.0% (0/0) 💚 10.104
Conditionals 100.0% (0/0) 💚

@CohenIdo CohenIdo changed the title mapping for rule id [Cloud Posture] mapping for rule id Jun 13, 2022
@CohenIdo CohenIdo marked this pull request as ready for review June 14, 2022 09:09
@CohenIdo CohenIdo requested a review from a team as a code owner June 14, 2022 09:09
@eyalkraft
Copy link
Contributor

reverting the constraint as well?

@CohenIdo
Copy link
Contributor Author

reverting the constraint as well?

I did the revert in different PR:

kfirpeled
kfirpeled requested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it up with @eyalkraft and we should create a new version, unlike what I've asked you to do - to edit the current one.
so please create version 0.0.14 and lower the condition for kibana to 8.3

@CohenIdo CohenIdo mentioned this pull request Jun 14, 2022
Closed
@CohenIdo CohenIdo requested a review from kfirpeled June 14, 2022 12:38
@CohenIdo CohenIdo merged commit 8a9d2bc into elastic:main Jun 14, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

@eyalkraft eyalkraft Awaiting requested review from eyalkraft

Assignees
No one assigned
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CohenIdo @elasticmachine @eyalkraft @kfirpeled