Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP - Update kibana version constrain #3505

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

uri-weisman
Copy link
Contributor

@uri-weisman uri-weisman commented Jun 14, 2022

What does this PR do?

Currently, we can only constrain an integration to a Kibana version.
Even though an old version of the elastic agent can run with newer versions of the Elastic stack it's still worth limiting the newer versions of the Integration to Kibana 8.4, which narrows down the possibility of running with the wrong cloudbeat version.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jun 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-14T07:16:51.422+0000

  • Duration: 14 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.497
Classes 100.0% (0/0) 💚 3.497
Methods 33.333% (1/3) 👎 -56.133
Lines 100.0% (0/0) 💚 9.079
Conditionals 100.0% (0/0) 💚

@uri-weisman uri-weisman marked this pull request as ready for review June 14, 2022 07:34
@uri-weisman uri-weisman requested a review from a team as a code owner June 14, 2022 07:34
@uri-weisman uri-weisman changed the title Update kibana version constrain CSP - Update kibana version constrain Jun 14, 2022
@uri-weisman uri-weisman merged commit 8cc0e2a into elastic:main Jun 14, 2022
@uri-weisman uri-weisman deleted the update_integration_constrain branch June 14, 2022 07:58
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants