Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ActiveMQ readme #3535

Merged
merged 3 commits into from
Jul 25, 2022
Merged

update ActiveMQ readme #3535

merged 3 commits into from
Jul 25, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Jun 20, 2022 •
edited
Loading

  • Enhancement

What does this PR do?

fixed a line break that was in the wrong place.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ellis-elastic
update readme
15efe7f 
fixed a line break that was in the wrong place.
@ellis-elastic ellis-elastic requested a review from a team as a code owner June 20, 2022 09:41
@ellis-elastic ellis-elastic mentioned this pull request Jun 20, 2022
Closed
4 tasks
@ellis-elastic
update changelog
0f6e3ee 
and ran build
@ellis-elastic ellis-elastic added documentation Improvements or additions to documentation enhancement New feature or request Integration:ActiveMQ labels Jun 20, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T08:55:08.717+0000

  • Duration: 21 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.941
Classes 100.0% (2/2) 💚 2.941
Methods 95.833% (23/24) 👍 6.583
Lines 83.838% (83/99) 👎 -6.744
Conditionals 100.0% (0/0) 💚

bmorelli25
bmorelli25 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error fix LGTM.

muthu-mps
muthu-mps approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellis-elastic ellis-elastic merged commit f1dede3 into elastic:main Jul 25, 2022
@ellis-elastic ellis-elastic deleted the ActiveMQ-docs branch July 25, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
documentation Improvements or additions to documentation enhancement New feature or request Integration:ActiveMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ellis-elastic @elasticmachine @bmorelli25 @muthu-mps