Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Fix pagination and missing fields #3607

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jun 27, 2022

What does this PR do?

Resolve issue of paignation and missing created_at field. I also updated the event.* categorization fields to be more accurate.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 marked this pull request as ready for review June 27, 2022 23:51
@legoguy1000 legoguy1000 requested a review from a team as a code owner June 27, 2022 23:51
@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T00:08:41.567+0000

  • Duration: 14 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 28, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.44
Classes 100.0% (1/1) 💚 3.44
Methods 100.0% (12/12) 💚 10.877
Lines 96.753% (149/154) 👍 6.718
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:github GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github audit logs pagination not working
3 participants