Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIS beta to ga #3620

Merged
merged 10 commits into from
Jul 21, 2022
Merged

IIS beta to ga #3620

merged 10 commits into from
Jul 21, 2022

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Jun 29, 2022 •
edited
Loading

What does this PR do?

Moving the IIS integration from beta to GA.

Checklist

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Install IIS server in the windows platform
  • Add IIS agent integration
  • Check whether the collect logs and metrics option is enabled
  • Verify the data is ingested into Elasticsearch
  • Check dashboards loads with the data and generates metrics

Since IIS is windows platform specific integration. Manual testing is performed and system testing is not added.

Related issues

@muthu-mps muthu-mps added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team labels Jun 29, 2022
@muthu-mps muthu-mps self-assigned this Jun 29, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T06:13:56.916+0000

  • Duration: 18 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.819
Classes 100.0% (2/2) 💚 3.819
Methods 85.714% (30/35) 👎 -1.187
Lines 91.781% (268/292) 👎 -1.181
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review June 30, 2022 10:49
@muthu-mps muthu-mps requested a review from a team as a code owner June 30, 2022 10:49
@ManojS-shetty ManojS-shetty self-requested a review July 14, 2022 08:30
ishleenk17
ishleenk17 reviewed Jul 18, 2022
View reviewed changes
packages/iis/data_stream/access/_dev/test/pipeline/test-iis-8.log
2019-08-14 00:09:32 W3SVC1 SE119654 ::1 GET /help/default.aspx area= 80 - ::1 HTTP/1.1 Mozilla/5.0+(compatible;+MSIE+9.0;+Windows+NT+6.1;+Trident/5.0) - - localhost 403 4 5 5279 136 0
2019-08-14 00:09:32 W3SVC1 SE119654 ::1 GET /help/default.aspx area= 80 - ::1 HTTP/1.1 Mozilla/5.0+(compatible;+MSIE+9.0;+Windows+NT+6.1;+Trident/5.0) - - localhost 403 4 5 5279 136 0
2019-08-14 00:12:02 W3SVC1 SE119654 10.60.79.142 GET /default.aspx - 80 - 10.60.74.238 HTTP/1.0 - - - - 403 4 5 1372 18 0
2019-08-14 00:13:10 W3SVC1 SE119654 10.60.79.142 GET /default.aspx - 80 - 10.60.74.238 HTTP/1.1 Mozilla/4.0+(compatible;+MSIE+8.0;+Windows+NT+5.1;+Trident/4.0) - - se119654.saifg.rbc.com 403 4 5 1353 313 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the ingest pipeline patterns for this format.
Do they already exist ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 - Please check for the pattern-4 in access log ingest pipeline. This is the pattern which applies for the above log lines.

lalit-satapathy
lalit-satapathy reviewed Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any changes to the dashboard image files?

packages/iis/data_stream/access/_dev/test/pipeline/test-iis-8.log-expected.json
],
"kind": "event",
"original": "2019-08-14 00:09:32 W3SVC1 SE119654 ::1 GET /help/default.aspx area= 80 - ::1 HTTP/1.1 Mozilla/5.0+(compatible;+MSIE+9.0;+Windows+NT+6.1;+Trident/5.0) - - localhost 403 4 5 5279 160 15",
"outcome": "failure",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what causes this event.outcome as "failure"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample log which we are processing is with http_status_code: 403. Based on the status code the outcome is marked as failure.

packages/iis/docs/README.md Show resolved Hide resolved
@muthu-mps
Copy link
Contributor Author

Are there any changes to the dashboard image files?

The only change is dashboard by reference changed to by-value.

@ishleenk17
Copy link
Contributor

ishleenk17 commented Jul 21, 2022 •
edited
Loading

I think it would be worth mentioning somewhere in a document (maybe under _dev) as to why system tests are not present.
We can link it to the issue where system tests not supported for windows issue is open.

Once this is taken care of, everything else looks addressed now.

ishleenk17
ishleenk17 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@muthu-mps muthu-mps merged commit c887500 into elastic:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy left review comments

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@ManojS-shetty ManojS-shetty Awaiting requested review from ManojS-shetty

Assignees

@muthu-mps muthu-mps

Labels
enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make IIS GA
4 participants
@muthu-mps @elasticmachine @ishleenk17 @lalit-satapathy