Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Metrics] Move container_service metrics from beats to integrations #3627

Merged
merged 2 commits into from
Jun 30, 2022
Merged

[Azure Metrics] Move container_service metrics from beats to integrations #3627

merged 2 commits into from
Jun 30, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jun 29, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations.

Switch from "container_service" to "monitor" metricset, add the metrics configuration from beats, and add an ingest pipeline to set the expected field names (azure.container_service.* instead of azure.metrics.*).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

@zmoog
Move container_service metrics from beats to integrations
7d079ce 
Switch from "container_service" to "monitor" metricset, add the
metrics configuration from beats, and add an ingest pipeline to
set the expected field names (`azure.container_service.*` instead
of `azure.metrics.*`).
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T21:31:10.727+0000

  • Duration: 14 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 55.172% (16/29) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@zmoog zmoog self-assigned this Jun 29, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jun 29, 2022
@zmoog zmoog marked this pull request as ready for review June 30, 2022 08:42
@zmoog zmoog requested a review from a team as a code owner June 30, 2022 08:42
tommyers-elastic
tommyers-elastic approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmoog zmoog merged commit 7a78c79 into elastic:main Jun 30, 2022
@zmoog zmoog deleted the rm-lw-mods-az-container_service branch June 30, 2022 14:43
@zmoog zmoog changed the title Move container_service metrics from beats to integrations [Azure Metrics] Move container_service metrics from beats to integrations Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from azure_metrics container_service data stream
3 participants
@zmoog @elasticmachine @tommyers-elastic