Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Metrics] Move database_account metrics from beats to integrations #3631

Merged
merged 5 commits into from
Jul 8, 2022
Merged

[Azure Metrics] Move database_account metrics from beats to integrations #3631

merged 5 commits into from
Jul 8, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jun 30, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations.

Switch from "database_account" to "monitor" metricset, add the metrics configuration from beats, and add an ingest pipeline to set the expected field names (azure.database_account.* instead of azure.metrics.*).

ℹ️ Note for reviewers: I will merge this PR after rebasing on main when #3629 is merged.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog zmoog self-assigned this Jun 30, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jun 30, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-08T08:23:56.638+0000

  • Duration: 14 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 30, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.171
Classes 100.0% (0/0) 💚 3.171
Methods 51.613% (16/31) 👎 -37.924
Lines 100.0% (0/0) 💚 8.916
Conditionals 100.0% (0/0) 💚

zmoog added 2 commits July 1, 2022 11:51
@zmoog
Move database_account metrics from beats to integrations
ae3098d 
Switch from "database_account" to "monitor" metricset, add the
metrics configuration from beats, and add an ingest pipeline to
set the expected field names (`azure.database_account.*` instead
of `azure.metrics.*`).
@zmoog
Update link to PR
ebacc43
@zmoog zmoog force-pushed the rm-lw-mods-az-database_account branch from 3cfa2dc to ebacc43 Compare July 1, 2022 09:53
@zmoog
Copy link
Contributor Author

zmoog commented Jul 1, 2022 •
edited
Loading

I will merge this PR after rebasing on main when #3629 is merged.

@zmoog zmoog marked this pull request as ready for review July 1, 2022 10:25
@zmoog zmoog requested a review from a team as a code owner July 1, 2022 10:25
@zmoog zmoog changed the title [Azure] Move database_account metrics from beats to integrations [Azure Metrics] Move database_account metrics from beats to integrations Jul 1, 2022
@tommyers-elastic tommyers-elastic merged commit a8f0045 into elastic:main Jul 8, 2022
@zmoog zmoog deleted the rm-lw-mods-az-database_account branch July 18, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from azure_metrics database_account data stream
3 participants
@zmoog @elasticmachine @tommyers-elastic