Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gaps in the Prometheus integration (technical preview) #3662

Merged

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Jul 7, 2022

…s; collector: add leader election, remove default value for ssl; query: add leader election

Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co

What does this PR do?

Those changes are the result of evaluation issue, for more details: #3489, #3487, #3488

remote_write datastream:

  • hide some configuration settings

collectordatastream:

  • add leader election
  • remove default value for ssl

query datastream:

  • add leader election

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

Collector:

  1. added leader election setting as an advanced option
  2. removed default values for ssl Certificate Authorities

Screenshot 2022-07-07 at 12 43 50

Query:

  1. added leader election setting as an advanced option

Screenshot 2022-07-07 at 12 44 02

remote_write:

  1. move some setting to advanced options:

Screenshot 2022-07-07 at 12 44 15

with advanced options:
Screenshot 2022-07-07 at 12 44 25

…s; collector: add leader election, remove default value for ssl; query: add leader election

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko added the enhancement New feature or request label Jul 7, 2022
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner July 7, 2022 10:59
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jul 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-07T11:00:57.147+0000

  • Duration: 13 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.171
Classes 100.0% (0/0) 💚 3.171
Methods 66.667% (6/9) 👎 -22.888
Lines 100.0% (0/0) 💚 8.916
Conditionals 100.0% (0/0) 💚

@@ -15,13 +15,18 @@ metrics_filters.include:
metrics_path: {{metrics_path}}
period: {{period}}
rate_counters: {{rate_counters}}
{{#if ssl.certificate_authorities}}
ssl.certificate_authorities:
{{#each ssl.certificate_authorities}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have many cert_authorities? Just wondering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
Screenshot 2022-07-07 at 16 50 21
it defined by multi: true setting in manifest

@tetianakravchenko tetianakravchenko merged commit 91619c5 into elastic:main Jul 8, 2022
@mlunadia mlunadia changed the title Prometheus integration: minor enhancements as an outcome of evaluation issues Prometheus integration: User experience enhancements Jul 8, 2022
@mlunadia mlunadia changed the title Prometheus integration: User experience enhancements Fix gaps in the Prometheus integration Jul 18, 2022
@mlunadia mlunadia changed the title Fix gaps in the Prometheus integration Fix gaps in the Prometheus integration (technical preview) Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants