suricata: add SNI to related.hosts for TLS events #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
commented
Jul 8, 2022
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
efd6
commented
Jul 8, 2022
Comment on lines
+64
to
+74
| - script: | ||
| lang: painless | ||
| if: ctx.host?.mac != null | ||
| source: | ||
| def fixup(ArrayList macs) { | ||
| for (def i = 0; i < macs.length; i++) { | ||
| macs[i] = macs[i].replace(':','-').toUpperCase(); | ||
| } | ||
| return macs; | ||
| } | ||
| ctx.host['mac'] = fixup(ctx.host?.mac); |
There was a problem hiding this comment.
This was tested manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the SNI host to
related.hostswhen the event is a TLS event and cleans up some template invocations.Checklist
changelog.ymlfile.Author's Checklist
forwardedis not set as a tag, the host information is present in events. It is not possible with current testing infrastructure to test this AFAICS.Note that the MAC address populated by libbeat does not conform to the ECS docs.How to test this PR locally
Related issues
Screenshots