Make cockroachDB GA #3676

ritalwar · 2022-07-11T10:14:24Z

Enhancement

What does this PR do?

This PR make CockroachDB release GA

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run the cockroachDB instance.
Add the integration and metrics should start flowing through Kibana.

Related issues

Closes Make CockroachDB GA #3550
Closes Move cockroachdb module to GA #480

Screenshots

elasticmachine · 2022-07-11T10:32:25Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-13T10:57:51.713+0000
Duration: 14 min 43 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4
Skipped	0
Total	4

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-07-11T10:32:42Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 2.703
Classes	100.0% (`0/0`)	💚 2.703
Methods	75.0% (`3/4`)	👎 -14.73
Lines	100.0% (`0/0`)	💚 8.611
Conditionals	100.0% (`0/0`)	💚

ishleenk17 · 2022-07-12T05:59:19Z

packages/cockroachdb/data_stream/status/agent/stream/stream.yml.hbs

-    - {{this}}
-{{/each}}
+    - raft_process_handleready_latency
+    - raft_scheduler_latency


For now are we excluding all the histogram metrics ?

Yes, once dynamic template mapping issue is resolved , will remove these from here.

ishleenk17 · 2022-07-12T06:01:21Z

ecs.yml and base-fields.yml is missing. Please add those

ishleenk17 · 2022-07-12T06:08:09Z

I think there is some issue with the basic structuring of the integration.
I don't see README under _dev/build.
That is used to generate the main rEADME. How are we getting the main README currently ?

ritalwar · 2022-07-12T06:14:04Z

I think there is some issue with the basic structuring of the integration. I don't see README under _dev/build. That is used to generate the main rEADME. How are we getting the main README currently ?

It is under _dev/build/docs, Please see : https://github.com/ritalwar/integrations/blob/migrate_cockroachdb_ga_3550/packages/cockroachdb/_dev/build/docs/README.md and this is being used to generate main README.

ishleenk17 · 2022-07-12T06:16:36Z

I think there is some issue with the basic structuring of the integration. I don't see README under _dev/build. That is used to generate the main rEADME. How are we getting the main README currently ?

It is under _dev/build/docs, Please see : https://github.com/ritalwar/integrations/blob/migrate_cockroachdb_ga_3550/packages/cockroachdb/_dev/build/docs/README.md and this is being used to generate main README.

My bad, I thought it to be a new integration. Hence was expecting all the files.

ritalwar · 2022-07-12T06:17:21Z

ecs.yml and base-fields.yml is missing. Please add those

It is already there, https://github.com/ritalwar/integrations/tree/migrate_cockroachdb_ga_3550/packages/cockroachdb/data_stream/status/fields

ishleenk17 · 2022-09-08T05:40:24Z

Does this work if no username/pwd is provided to the db ? As I don't see any default value for it.
We are doing a * mapping for the fields. As you informed there are around 950 metrics that get exported.
Are we making all of these available for user ? The sample json file has a subset of these.

ishleenk17 · 2022-09-08T06:15:27Z

Have we tested the integrations with bearer token and ssl.certificate_authorities input ?
Since that is available as a user input.

packages/cockroachdb/_dev/deploy/docker/docker-compose.yml

ritalwar · 2022-09-12T16:13:23Z

Does this work if no username/pwd is provided to the db ? As I don't see any default value for it.

Yes, it works without username and pwd also and if DB is secured by username/pwd then we can provide this. These are optional fields hence no default value.

We are doing a * mapping for the fields. As you informed there are around 950 metrics that get exported.
Are we making all of these available for user ? The sample json file has a subset of these.

Yes, all these are available for user.

ishleenk17 · 2022-09-13T06:09:07Z

Yes, all these are available for user.

The sample json is quite a smaller set. Are those cumulative values of those counters ?

ritalwar · 2022-09-13T09:28:12Z

Yes, all these are available for user.

The sample json is quite a smaller set. Are those cumulative values of those counters ?

No, I think that's because of cockroachdb version getting used in system test, with this version these many fields were generated and I reported around 900 fields with latest version of cockroachDb i.e v22.1.6.
I tried with same version of cockroachDb in system test also and now the field count in sample_event.json is almost same, shall I update this version and commit this sample_event.json file?

ishleenk17 · 2022-09-13T09:57:17Z

Yes, all these are available for user.

The sample json is quite a smaller set. Are those cumulative values of those counters ?

No, I think that's because of cockroachdb version getting used in system test, with this version these many fields were generated and I reported around 900 fields with latest version of cockroachDb i.e v22.1.6. I tried with same version of cockroachDb in system test also and now the field count in sample_event.json is almost same, shall I update this version and commit this sample_event.json file?

I think verifying this should be sufficient. Having those many fields listed on the UI is not required.

ritalwar · 2022-09-20T02:58:40Z

Have we tested the integrations with bearer token and ssl.certificate_authorities input ? Since that is available as a user input.

Yes, Testing has been done with both the options now.

ishleenk17

Looks good!

ritalwar added 2 commits July 11, 2022 15:37

Make cockroachDB GA

db9b05f

update changelog.yml

c36e2e4

Update dashboard by value

56c6b5a

ishleenk17 reviewed Jul 12, 2022

View reviewed changes

andrewkroh added Integration:cockroachdb CockroachDB Metrics Team:Service-Integrations Label for the Service Integrations team labels Aug 15, 2022

update histogram changes

3e42f3e

ritalwar marked this pull request as ready for review September 6, 2022 10:11

ritalwar requested a review from a team as a code owner September 6, 2022 10:11

ritalwar mentioned this pull request Sep 8, 2022

Make CockroachDB GA #3550

Closed

8 tasks

ishleenk17 reviewed Sep 8, 2022

View reviewed changes

packages/cockroachdb/_dev/deploy/docker/docker-compose.yml Show resolved Hide resolved

ishleenk17 approved these changes Sep 20, 2022

View reviewed changes

ritalwar merged commit bc887ef into elastic:main Sep 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make cockroachDB GA #3676

Make cockroachDB GA #3676

ritalwar commented Jul 11, 2022 •

edited

Loading

elasticmachine commented Jul 11, 2022 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Jul 11, 2022 •

edited

Loading

ishleenk17 Jul 12, 2022

ritalwar Jul 12, 2022

ishleenk17 commented Jul 12, 2022

ishleenk17 commented Jul 12, 2022

ritalwar commented Jul 12, 2022

ishleenk17 commented Jul 12, 2022

ritalwar commented Jul 12, 2022

ishleenk17 commented Sep 8, 2022

ishleenk17 commented Sep 8, 2022

ritalwar commented Sep 12, 2022

ishleenk17 commented Sep 13, 2022

ritalwar commented Sep 13, 2022 •

edited

Loading

ishleenk17 commented Sep 13, 2022

ritalwar commented Sep 20, 2022

ishleenk17 left a comment

Make cockroachDB GA #3676

Make cockroachDB GA #3676

Conversation

ritalwar commented Jul 11, 2022 • edited Loading

What does this PR do?

Checklist

How to test this PR locally

Related issues

Screenshots

elasticmachine commented Jul 11, 2022 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Jul 11, 2022 • edited Loading

🌐 Coverage report

ishleenk17 Jul 12, 2022

Choose a reason for hiding this comment

ritalwar Jul 12, 2022

Choose a reason for hiding this comment

ishleenk17 commented Jul 12, 2022

ishleenk17 commented Jul 12, 2022

ritalwar commented Jul 12, 2022

ishleenk17 commented Jul 12, 2022

ritalwar commented Jul 12, 2022

ishleenk17 commented Sep 8, 2022

ishleenk17 commented Sep 8, 2022

ritalwar commented Sep 12, 2022

ishleenk17 commented Sep 13, 2022

ritalwar commented Sep 13, 2022 • edited Loading

ishleenk17 commented Sep 13, 2022

ritalwar commented Sep 20, 2022

ishleenk17 left a comment

Choose a reason for hiding this comment

ritalwar commented Jul 11, 2022 •

edited

Loading

elasticmachine commented Jul 11, 2022 •

edited

Loading

elasticmachine commented Jul 11, 2022 •

edited

Loading

ritalwar commented Sep 13, 2022 •

edited

Loading