Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_umbrella] Enrich DNS fields #3712

Merged
merged 3 commits into from
Jul 20, 2022
Merged

[cisco_umbrella] Enrich DNS fields #3712

merged 3 commits into from
Jul 20, 2022

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Jul 14, 2022

What does this PR do?

Enriches the dns fields from dns.question.name to dns.question.registered_domain, dns.question.top_level_domain and dns.question.sudomain.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Review that enrichment is happening

Related issues

@LaZyDK LaZyDK requested a review from a team as a code owner July 14, 2022 11:12
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Jul 14, 2022

@P1llus Please see if this works before merging.

@elasticmachine
Copy link

elasticmachine commented Jul 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T20:22:27.073+0000

  • Duration: 16 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

elasticmachine commented Jul 14, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.049
Classes 100.0% (1/1) 💚 3.049
Methods 94.444% (17/18) 👍 5.359
Lines 92.837% (324/349) 👍 2.631
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title [Cisco Umbrella] Enrich DNS fields [cisco_umbrella] Enrich DNS fields Jul 14, 2022
@andrewkroh andrewkroh added the enhancement New feature or request label Jul 14, 2022
@andrewkroh
Copy link
Member

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:cisco_umbrella Cisco Umbrella
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants