Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Move usage lightweight module config into integration #3764

Merged
merged 3 commits into from
Jul 26, 2022
Merged

[AWS] Move usage lightweight module config into integration #3764

merged 3 commits into from
Jul 26, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 19, 2022

What does this PR do?

This PR is to move lightweight module configuration from metricbeat into integrations for usage.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

closes #3606
closes #3597

@kaiyan-sheng kaiyan-sheng self-assigned this Jul 19, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T22:12:27.720+0000

  • Duration: 36 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 332
Skipped 0
Total 332

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.432
Classes 91.667% (11/12) 👎 -5.432
Methods 82.692% (172/208) 👎 -6.639
Lines 92.894% (2157/2322) 👍 2.319
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review July 25, 2022 22:12
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 25, 2022 22:12
@kaiyan-sheng kaiyan-sheng added Integration:AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 25, 2022
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 471d1be into elastic:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
3 participants