Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[couchbase] Add Integration Package with Node Data Stream #3771

Merged
merged 8 commits into from Oct 18, 2022

Conversation

bhagyaraj-crest
Copy link
Contributor

@bhagyaraj-crest bhagyaraj-crest commented Jul 20, 2022

  • Enhancement

What does this PR do?

  • Generated the skeleton of Couchbase integration package.
  • Added 1 data stream ( node )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.
  • Update Manifest related changes to bring host variables in the package level and also update relative changes in the .hbs files and test files

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/couchbase directory.
  • Run the following command to run tests.

elastic-package test

ss1
ss2

Related issues

@elasticmachine
Copy link

elasticmachine commented Jul 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T12:48:37.384+0000

  • Duration: 30 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani yug-rajani added enhancement New feature or request Integration:Couchbase Team:Service-Integrations Label for the Service Integrations team labels Jul 20, 2022
@yug-rajani yug-rajani linked an issue Jul 20, 2022 that may be closed by this pull request
8 tasks
@yug-rajani
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Jul 20, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚 2.525
Classes 100.0% (10/10) 💚 2.525
Methods 100.0% (72/72) 💚 9.359
Lines 100.0% (1076/1076) 💚 8.626
Conditionals 100.0% (0/0) 💚

@yug-rajani
Copy link
Contributor

/test

Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please change as per the nits suggested in #3666

@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

🚀 Benchmarks report

Package couchbase 👍(7) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cluster 19607.84 16129.03 -3478.81 (-17.74%) 💔

To see the full report comment with /test benchmark fullreport

@kush-elastic kush-elastic marked this pull request as ready for review October 12, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Couchbase Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Couchbase package
5 participants