Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add storage data stream #3785

Merged
merged 16 commits into from
Aug 24, 2022
Merged

[GCP] Add storage data stream #3785

merged 16 commits into from
Aug 24, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jul 21, 2022

What does this PR do?

Adds storage data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-24T12:42:35.406+0000

  • Duration: 19 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 76
Skipped 0
Total 76

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.825
Classes 100.0% (5/5) 💚 2.825
Methods 93.258% (83/89) 👍 3.877
Lines 95.752% (1375/1436) 👍 4.755
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review July 26, 2022 13:32
@gpop63 gpop63 requested review from a team as code owners July 26, 2022 13:32
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
endorama
endorama requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change but LGTM!

packages/gcp/changelog.yml Outdated
@@ -32,6 +32,9 @@
- description: Add GCP Firestore Data stream
type: enhancement
link: https://github.com/elastic/integrations/pull/2704
- description: Add GCP Storage Data Stream
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target the most recent version of this package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@gpop63 gpop63 requested a review from endorama August 8, 2022 21:33
gpop63 and others added 6 commits August 17, 2022 22:27
@gpop63
bump to 2.7.0
215ac40
@gpop63
Merge remote-tracking branch 'upstream/main' into add_gcp-storage
f2d9663
@endorama
Update manifest.yml
efe5ae5
@endorama
Update changelog.yml
41c69fb
@endorama
Revert "Update manifest.yml"
c6ace1e 
This reverts commit efe5ae5.

Bump to 2.7.0 was correct so this PR can be merged after elastic#3493
@endorama
Revert "Update changelog.yml"
bcf733d 
This reverts commit 41c69fb.

Bump to 2.7.0 was correct so this PR can be merged after elastic#3493
@endorama
Copy link
Member

/test

@endorama
Copy link
Member

I cannot reproduce the failure locally, as the same check (elastic-package check -v) does not produce any error.

tommyers-elastic
tommyers-elastic requested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo in metric name

packages/gcp/data_stream/storage/fields/fields.yml Outdated Show resolved Hide resolved
@tommyers-elastic
Fix typo in metric name
e18fa97 
`authz.acl_based_object_access_.ount` -> `authz.acl_based_object_access_.count`
tommyers-elastic
tommyers-elastic approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit 10f10c4 into elastic:main Aug 24, 2022
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GCP] Migrate gcp.storage metricset to data stream
4 participants
@gpop63 @elasticmachine @endorama @tommyers-elastic