Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infoblox_nios] Update ECS to 8.4.0 #3893

Merged
merged 3 commits into from
Jul 29, 2022
Merged

[infoblox_nios] Update ECS to 8.4.0 #3893

merged 3 commits into from
Jul 29, 2022

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Jul 28, 2022 •
edited
Loading

  • update infoblox_nios to ECS 8.4.0
  • switch to ECS allowed values in dns.header_flags, original values are now in infoblox_nios.log.dns.header_flags

Closes #3884

@leehinman leehinman force-pushed the 3884_infoblox_nios_dns_header_flags branch from 1cad647 to 2bcff34 Compare July 28, 2022 20:16
@elasticmachine
Copy link

elasticmachine commented Jul 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T20:17:02.811+0000

  • Duration: 16 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 35
Skipped 0
Total 35

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@leehinman leehinman changed the title Update ECS to 8.4.0 [infoblox_nios] Update ECS to 8.4.0 Jul 28, 2022
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.874
Classes 100.0% (4/4) 💚 2.874
Methods 97.297% (36/37) 👍 8.04
Lines 98.804% (413/418) 👍 8.187
Conditionals 100.0% (0/0) 💚

@leehinman leehinman marked this pull request as ready for review July 28, 2022 20:39
@leehinman leehinman requested a review from a team as a code owner July 28, 2022 20:39
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leehinman leehinman merged commit 88620bc into elastic:main Jul 29, 2022
@leehinman leehinman deleted the 3884_infoblox_nios_dns_header_flags branch July 29, 2022 14:21
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[infoblox_nios] ECS 8.4.0 dns.header_flags expected values mismatch
3 participants
@leehinman @elasticmachine @efd6