Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco Meraki] Fix client.geo.location mapping #3941

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix client.geo.location mapping from object to geo_point.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 2, 2022 23:38
@elasticmachine
Copy link

elasticmachine commented Aug 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T05:22:25.333+0000

  • Duration: 19 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
Copy link
Contributor

efd6 commented Aug 8, 2022

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.918
Classes 100.0% (9/9) 💚 2.918
Methods 100.0% (64/64) 💚 10.444
Lines 99.289% (1117/1125) 👍 7.71
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 0596b16 into elastic:main Aug 8, 2022
@legoguy1000 legoguy1000 deleted the 3938-cisco-geo-fix branch August 8, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meraki Fields Conflict with Okta
3 participants