Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cassandra] Update as per best practices #3948

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

harnish-crest
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR enhances the Cassandra integration with some of the best practices of developing integration packages.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/couchbase directory.
  • Run the following command to run tests.

elastic-package test

@harnish-crest harnish-crest requested a review from a team as a code owner August 3, 2022 12:57
@elasticmachine
Copy link

elasticmachine commented Aug 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-17T05:18:35.434+0000

  • Duration: 17 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

elasticmachine commented Aug 3, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.913
Classes 100.0% (1/1) 💚 2.913
Methods 100.0% (13/13) 💚 10.3
Lines 91.228% (52/57) 👎 -0.515
Conditionals 100.0% (0/0) 💚

@yug-rajani yug-rajani added enhancement New feature or request Integration:Cassandra Team:Service-Integrations Label for the Service Integrations team labels Aug 4, 2022
@ManojS-shetty ManojS-shetty self-requested a review August 4, 2022 07:03
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yug-rajani yug-rajani merged commit a77c3a0 into elastic:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Cassandra Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants