Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the ML jobs query for the LotL Attack Detection Package #3999

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

ajosh0504
Copy link
Contributor

@ajosh0504 ajosh0504 commented Aug 15, 2022

What does this PR do?

While testing changes made in this PR in the snapshot environment, we found that the ML jobs module for the LotL Attack Detection package does not show up if no malicious events were seen by the ingest pipeline. This is not expected behavior. This PR fixes that.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Build the latest ProblemChild package from this branch
  • Stand up a cluster using elastic-package
  • Add the LotL Attack Detection integration
  • Create a test index with the default index pipeline as the ProblemChild ingest pipeline and mappings for the problemchild prediction and blocklist fields
  • Ingest a dummy Windows process event document in the test index which is known to produce a prediction of 0 from the ProblemChild supervised model
  • Create a data view for the test index
  • Select the test index at the Create Job stage in the Anomaly Detection UI
  • Ensure that you see the ProblemChild module appear
  • Enable the jobs and make sure they start without errors

Screenshots

  • Test index with no malicious events

Screen Shot 2022-08-15 at 1 06 35 PM

  • Ensuring that the ProblemChild ML job module shows up for the data view corresponding to the test index

Screen Shot 2022-08-15 at 1 06 56 PM

  • Ensuring that all the jobs were enabled successfully

Screen Shot 2022-08-15 at 1 07 14 PM

@ajosh0504 ajosh0504 added the bug Something isn't working label Aug 15, 2022
@ajosh0504 ajosh0504 requested a review from a team as a code owner August 15, 2022 20:09
@elasticmachine
Copy link

elasticmachine commented Aug 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-15T20:10:46.295+0000

  • Duration: 15 min 16 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@ajosh0504 ajosh0504 merged commit 3e5e2ad into main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants