Update CSP mapping fields #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Note that the change log and the manifest must be updated as well |
andrewkroh
added
the
Integration:cloud_security_posture
olegsu
force-pushed
the
csp-findings-mapping
branch
2 times, most recently
from
8c1ebc6
to
5e238fd
Compare
🌐 Coverage report
|
kfirpeled
requested changes
Aug 22, 2022
| @@ -1,4 +1,18 @@ | |||
| - name: cluster_id | |||
| type: keyword | |||
| - name: cycle_id | |||
| type: keyword | |||
| - name: event.category | |||
There was a problem hiding this comment.
please place these fields' definition in ecs.yml
Also, consider adding the actual type they have, otherwise it uses the default which is keyword.
for example: event.created is of type date
olegsu
force-pushed
the
csp-findings-mapping
branch
2 times, most recently
from
1a77c4c
to
672d76d
Compare
olegsu
force-pushed
the
csp-findings-mapping
branch
5 times, most recently
from
e001f0b
to
b49a6e4
Compare
olegsu
force-pushed
the
csp-findings-mapping
branch
from
b49a6e4
to
26f15d1
Compare
olegsu
force-pushed
the
csp-findings-mapping
branch
from
26f15d1
to
63e63e2
Compare
|
/test |
kfirpeled
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the mapping CSP uses based on elastic/cloudbeat#346
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots