-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zscaler_zia] Remap network.protocol/scheme to valid values for uri_parts #4045
Conversation
- Add script processor to build URL for parsing. Script has parameters for valid protocols and a default protocol for a fallback. If network.protocol is valid, then it is used, otherwise the protocol (scheme) used for the URL will be the default (fallback) protocol. The original network.protocol is preserved. - Removed redundant processors - Add test cases - Rename test case files to comply with package spec - Regenerate pipeline test expected files
Side note, system test files/sample events were not regenerated due to: #4044 |
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably worth noting in the package readme that if there is not a valid scheme then the scheme is set to https.
What does this PR do?
protocols and a default protocol for a fallback. If network.protocol is valid,
then it is used, otherwise the protocol (scheme) used for the URL will be
the default (fallback) protocol. The original network.protocol is preserved.
Checklist
changelog.yml
file.How to test this PR locally
Related issues