Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cisco Umbrella] Fix Proxy Log CSV fields #4085

Merged
merged 7 commits into from
Sep 7, 2022
Merged

[Cisco Umbrella] Fix Proxy Log CSV fields #4085

merged 7 commits into from
Sep 7, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix Proxy Log CSV fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 28, 2022 22:22
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T02:18:35.625+0000

  • Duration: 14 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Aug 28, 2022

/test

1 similar comment
@efd6
Copy link
Contributor

efd6 commented Aug 29, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Aug 29, 2022

/test

@elasticmachine
Copy link

elasticmachine commented Aug 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.809
Classes 100.0% (1/1) 💚 2.809
Methods 94.444% (17/18) 👍 5.049
Lines 92.938% (329/354) 👍 1.997
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

@efd6 Updated and ready for review/tests

@efd6
Copy link
Contributor

efd6 commented Sep 7, 2022

/test

@efd6 efd6 merged commit 6a0b906 into elastic:main Sep 7, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 13, 2022
Merged
@efd6 efd6 mentioned this pull request Sep 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrojmp leandrojmp leandrojmp left review comments

@matthiasledergerber matthiasledergerber matthiasledergerber left review comments

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Integration:Cisco Umbrella
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cisco Umbrella Proxylogs integration fields order is different from Cisco documentation.
6 participants
@legoguy1000 @elasticmachine @efd6 @leandrojmp @matthiasledergerber @andrewkroh