Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_umbrella] trailing forward slash hint removal #4093

Merged
merged 6 commits into from Sep 28, 2022
Merged

[cisco_umbrella] trailing forward slash hint removal #4093

merged 6 commits into from Sep 28, 2022

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Aug 30, 2022

What does this PR do?

I removed the hint for Cisco Managed S3 Bucket instructing us to put a forward slash at the end of the Bucket List Prefix.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

v1.3.1 - Remove hint for cisco managed s3 Bucket List Prefix
Update version
Remove hint for cisco managed s3 Bucket List Prefix
@LaZyDK LaZyDK requested a review from a team as a code owner August 30, 2022 06:16
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-28T08:49:04.649+0000

  • Duration: 13 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Aug 30, 2022

@P1llus test :)

@efd6
Copy link
Contributor

efd6 commented Aug 30, 2022

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus self-requested a review September 28, 2022 08:44
@P1llus P1llus self-assigned this Sep 28, 2022
@P1llus
Copy link
Member

P1llus commented Sep 28, 2022

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 94.444% (17/18)
Lines 92.938% (329/354)
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit 85b0af6 into elastic:main Sep 28, 2022
@LaZyDK LaZyDK deleted the LaZyDK-umbrella-hint-patch-1 branch October 5, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cisco_umbrella] Remove hint for cisco managed s3 Bucket List Prefix
5 participants