[kubernetes] remove overlapping field in state_job data_stream #4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
gizas
reviewed
Aug 30, 2022
| @@ -80,6 +80,7 @@ | |||
| Kubernetes statefulset name | |||
|
|
|||
| - name: job.name | |||
| dimension: true | |||
There was a problem hiding this comment.
it is to merge job.name field definition with the definition I've removed:
- name: kubernetes.job
type: group
fields:
- name: name
dimension: true
type: keyword
description: >
The name of the job resource
gizas
approved these changes
Aug 30, 2022
gsantoro
reviewed
Aug 30, 2022
| @@ -80,6 +80,7 @@ | |||
| Kubernetes statefulset name | |||
|
|
|||
| - name: job.name | |||
| dimension: true | |||
There was a problem hiding this comment.
it's interesting that we decided to add those kubernetes fields to base-fields. I thought we only had data_stream and @timestamp in the base-fields.yml and keep all the others in fields.yml
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co
What does this PR do?
remove overlapping fields in state_job data_stream, that causes some inconsistency (like mentioned here)
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots