Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ti_abusech] Change abusech.malwarebazaar.code_sign to Nested field #4102

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fixes a field mapping exception with abusech.malwarebazaar.code_sign. Changed the field mapping to Nested from Keyword.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 31, 2022 00:13
@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-05T23:36:42.252+0000

  • Duration: 18 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Aug 31, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Aug 31, 2022

There is probably more to this than just changing the mapping. See elastic/beats#31552.

@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.896
Classes 100.0% (4/4) 💚 2.896
Methods 100.0% (51/51) 💚 10.424
Lines 89.636% (493/550) 👎 -2.116
Conditionals 100.0% (0/0) 💚

@efd6
Copy link
Contributor

efd6 commented Aug 31, 2022

/test

@legoguy1000
Copy link
Contributor Author

@efd6 can we rerun tests?

@efd6
Copy link
Contributor

efd6 commented Sep 5, 2022

/test

@legoguy1000
Copy link
Contributor Author

@efd6 GTG??

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbuseCH | failed to parse field [abusech.malwarebazaar.code_sign] of type [keyword]
3 participants