Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threat Intelligence Dashboard fix #4106

Merged
merged 8 commits into from
Sep 1, 2022

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Aug 31, 2022

What does this PR do?

Updating the dashboard to point to data views by name instead of a GUID.

How to test this PR locally

Install the assets from the integration and verify that the dashboard doesn't show an error like Could not find the data view: b2a3b629-f629-4f2d-b437-9640f850312d

Related issues

Relates https://github.com/elastic/security-team/issues/4706

Screenshots

Was:
Screen Shot 2022-08-31 at 6 27 32 PM

Now is:
Screen Shot 2022-08-31 at 6 27 39 PM

@kgeller kgeller self-assigned this Aug 31, 2022
@kgeller kgeller requested a review from a team as a code owner August 31, 2022 22:29
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T23:15:05.743+0000

  • Duration: 14 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kgeller
Copy link
Contributor Author

kgeller commented Aug 31, 2022

@elasticmachine /test

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller merged commit 3ea6e31 into elastic:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants