Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws additional auth options #4168

Merged
merged 1 commit into from
Sep 11, 2022
Merged

feat: add aws additional auth options #4168

merged 1 commit into from
Sep 11, 2022

Conversation

olegsu
Copy link
Contributor

@olegsu olegsu commented Sep 8, 2022

What does this PR do?

Add additional AWS auth options (https://github.com/elastic/security-team/issues/4495)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Related https://github.com/elastic/security-team/issues/4495

Screenshots

image

@olegsu olegsu requested a review from a team as a code owner September 8, 2022 11:59
@elasticmachine
Copy link

elasticmachine commented Sep 8, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-11T07:25:26.380+0000

  • Duration: 13 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@olegsu
Copy link
Contributor Author

olegsu commented Sep 8, 2022

/test

ofiriro3
ofiriro3 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ofiriro3 ofiriro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ofiriro3
Copy link
Contributor

ofiriro3 commented Sep 8, 2022

I am not sure that the integration CI error is related to your work - please double check me

@orouz
Copy link
Contributor

orouz commented Sep 8, 2022

LGTM

just to be sure, can you please verify that after creating an integration, the agent policy still includes our runtime config?

Screen Shot 2022-09-08 at 17 56 58

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.874
Classes 100.0% (0/0) 💚 2.874
Methods 25.0% (1/4) 👎 -64.776
Lines 100.0% (0/0) 💚 8.181
Conditionals 100.0% (0/0) 💚

@orouz orouz mentioned this pull request Sep 11, 2022
Merged
4 tasks
@olegsu
Copy link
Contributor Author

olegsu commented Sep 11, 2022

@orouz
Seems ok
image

@olegsu olegsu merged commit 32ae490 into elastic:main Sep 11, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofiriro3 ofiriro3 ofiriro3 approved these changes

Assignees
No one assigned
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@olegsu @elasticmachine @ofiriro3 @orouz @kfirpeled