Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_asa: fix handling of non-canonical 113005 messages #4189

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 12, 2022

What does this PR do?

This relaxes the parsing of 113005 messages that do not conform to the documented format but appear in the wild.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Note that this actually tightens the format requirement on usernames since they must now actually satisfy the Cisco username syntax while before any non-space would be accepted.

How to test this PR locally

Related issues

Screenshots

This also required modification of an already existing log line test
input which was using an invalid username placeholder.
@efd6 efd6 self-assigned this Sep 12, 2022
@efd6 efd6 marked this pull request as ready for review September 12, 2022 10:25
@efd6 efd6 requested a review from a team as a code owner September 12, 2022 10:25
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-12T10:18:26.575+0000

  • Duration: 16 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚
Lines 83.827% (1555/1855)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:CiscoASA Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco_asa: failing to parse non-canonical 113005 message
3 participants