Set default endpoint for AWS to empty string

[kaiyan-sheng]

What does this PR do?

This PR is a follow up for #4103 to fix the same bug in cloudflare_logpush package.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-09-20T19:24:16.481+0000

• Duration: 19 min 56 sec

Test stats 🧪

Test	Results
Failed	0
Passed	44
Skipped	0
Total	44

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (7/7)	💚
Files	100.0% (7/7)	💚
Classes	100.0% (7/7)	💚
Methods	100.0% (89/89)	💚
Lines	94.37% (2380/2522)	❕
Conditionals	100.0% (0/0)	💚

[aspacca]

@kaiyan-sheng thanks for taking care of this

I would add exposing default_region like in #4158

[aspacca]

let's remove endpoint and add default_region, what do you think?

[kaiyan-sheng]

@aspacca I was originally thinking to add default_region in #4158 :) I can definitely add it here.

[aspacca]

hi @kaiyan-sheng we can remove endpoint at all, since as far as I can see the integrations does not support fetching from a non aws s3 compatible bucket

@elastic/security-external-integrations could you confirm?

the contrary, as it was confirmed: https://developers.cloudflare.com/logs/get-started/enable-destinations/s3-compatible-endpoints/

but this probably means that in case of non default logs collection via s3 direct access is working only on effective aws cloud bucket: for compatible non-aws s3 buckets the variable to set is non_aws_bucket along with a proper endpoint

[aspacca]

sorry @kaiyan-sheng I've realised after merging #4158 that the changes were made there.

I guess this PR can be closed now.

still there is the topic for this integration about:

but this probably means that in case of non default logs collection via s3 direct access is working only on effective aws cloud bucket: for compatible non-aws s3 buckets the variable to set is non_aws_bucket along with a proper endpoint

[kaiyan-sheng]

@aspacca No worries! Thanks for checking!!

I think we still need to set endpoint default value to empty string instead.

[elasticmachine]

🚀 Benchmarks report

Package cloudflare_logpush 👍(6) 💚(0) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
dns	5405.41	4016.06	-1389.35 (-25.7%)	💔

To see the full report comment with /test benchmark fullreport