Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MongoDb]Updated host.hostname field use FQDN of the host #4216

Merged
merged 8 commits into from Oct 18, 2022
Merged

[MongoDb]Updated host.hostname field use FQDN of the host #4216

merged 8 commits into from Oct 18, 2022

Conversation

ManojS-shetty
Copy link
Contributor

@ManojS-shetty ManojS-shetty commented Sep 14, 2022 •
edited

  • Bug

What does this PR do?

This PR adds the FQDN of the host and refactored the default pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Configure the mongodb log file path in Integration UI.
  • log data should flow in to the kibana.

Related issues

@ManojS-shetty
Updated ecs fields and default pipeline
d7d9763 
	modified:   packages/mongodb/changelog.yml
	modified:   packages/mongodb/data_stream/log/elasticsearch/ingest_pipeline/default.yml
	modified:   packages/mongodb/data_stream/log/fields/base-fields.yml
	modified:   packages/mongodb/data_stream/log/fields/ecs.yml
	modified:   packages/mongodb/docs/README.md
	modified:   packages/mongodb/manifest.yml
@ManojS-shetty ManojS-shetty self-assigned this Sep 14, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-18T06:13:27.846+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 14, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.759
Classes 100.0% (3/3) 💚 2.759
Methods 81.818% (27/33) 👎 -8.431
Lines 70.248% (85/121) 👎 -21.253
Conditionals 100.0% (0/0) 💚

@ManojS-shetty ManojS-shetty marked this pull request as ready for review September 14, 2022 11:09
@ManojS-shetty ManojS-shetty requested a review from a team as a code owner September 14, 2022 11:09
@ManojS-shetty
Updated changelog entry
8c4253f 
	modified:   packages/mongodb/changelog.yml
@ManojS-shetty
added only fqdn field changes
406fe7b 
	modified:   packages/mongodb/data_stream/log/elasticsearch/ingest_pipeline/default.yml
	modified:   packages/mongodb/data_stream/log/fields/base-fields.yml
	modified:   packages/mongodb/docs/README.md
@ManojS-shetty ManojS-shetty mentioned this pull request Sep 27, 2022
Closed
@ManojS-shetty ManojS-shetty changed the title [MongoDb]Updated ecs fields and default pipeline [MongoDb]Updated host.hostname field use FQDN of the host Sep 27, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022 •
edited

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ManojS-shetty ManojS-shetty added the Team:Service-Integrations Label for the Service Integrations team label Oct 5, 2022
ManojS-shetty and others added 2 commits October 11, 2022 10:11
@ManojS-shetty
Updated changelog to address conflicts
2b96447 
	modified:   packages/mongodb/changelog.yml
	modified:   packages/mongodb/manifest.yml
@ManojS-shetty
Merge branch 'main' into mongo_bugfixes
41b4a09
@agithomas
Copy link
Contributor

@ManojS-shetty , looks like the CI job pr-merge is blocked.
Also, please do see the need of having new sample-events.json checked in with the modified field structure.
Any change in fields.yml ?

@ManojS-shetty
Updated log sample event json
e81c634 
	modified:   packages/mongodb/data_stream/log/sample_event.json
@ManojS-shetty
Updated sample event json
7b450f2 
	modified:   packages/mongodb/data_stream/log/sample_event.json
@ManojS-shetty
Copy link
Contributor Author

ManojS-shetty commented Oct 11, 2022 •
edited

@ManojS-shetty , looks like the CI job pr-merge is blocked. Also, please do see the need of having new sample-events.json checked in with the modified field structure. Any change in fields.yml ?

@agithomas

  • Addressed CI pr merge conflict.
  • There is no change for fields.yml.
  • sample_event generated has been updated with latest structure.

@ManojS-shetty
Updated the ECS version to latest
bb46c19 
	modified:   packages/mongodb/_dev/build/build.yml
@ManojS-shetty ManojS-shetty merged commit 558bc94 into elastic:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

Assignees

@ManojS-shetty ManojS-shetty

Labels
Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoDB Integration using old ECS Version
3 participants
@ManojS-shetty @elasticmachine @agithomas