Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoblox_nios: fix configuration page #4233

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 20, 2022

What does this PR do?

This fixes a duplication of the log file input path in the configuration page for infoblox_nios. It also harmonises the input title for the file input with the two others. See screenshots below.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before this change:
Screenshot 2022-09-19 at 12 14 09

After this change:
Screen Shot 2022-09-20 at 12 25 36

@elasticmachine
Copy link

elasticmachine commented Sep 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-20T03:02:42.392+0000

  • Duration: 15 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

Package infoblox_nios 👍(1) 💚(0) 💔(0)

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (37/37) 💚
Lines 95.455% (462/484)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review September 20, 2022 03:22
@efd6 efd6 requested a review from a team as a code owner September 20, 2022 03:22
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Infoblox_nios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants