Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System] Remove incorrect tag #4248

Merged
merged 3 commits into from Oct 7, 2022
Merged

[System] Remove incorrect tag #4248

merged 3 commits into from Oct 7, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Remove incorrect tag

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner September 20, 2022 21:46
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-07T01:44:40.623+0000

  • Duration: 15 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 246
Skipped 0
Total 246

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 mentioned this pull request Sep 29, 2022
Closed
@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022 •
edited

🚀 Benchmarks report

Package system 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
security 962.46 766.87 -195.59 (-20.32%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.609
Classes 100.0% (4/4) 💚 2.609
Methods 60.759% (48/79) 👎 -29.307
Lines 98.793% (2702/2735) 👍 7.253
Conditionals 100.0% (0/0) 💚

@legoguy1000
Copy link
Contributor Author

can this be merged?

@andrewkroh andrewkroh merged commit e882176 into elastic:main Oct 7, 2022
@legoguy1000 legoguy1000 deleted the 4188-typo branch October 7, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@herrBez herrBez herrBez left review comments

@belimawr belimawr belimawr approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry was automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[system] Auth logs default config: remove 'hashicorp-vault-logs' tag
5 participants
@legoguy1000 @elasticmachine @belimawr @andrewkroh @herrBez