Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[salesforce] Add salesforce package foundation along with logout_rest data stream #4323

Merged
merged 11 commits into from
Dec 19, 2022

Conversation

yug-rajani
Copy link
Contributor

@yug-rajani yug-rajani commented Sep 27, 2022

  • Enhancement

What does this PR do?

  • Generated the skeleton of Salesforce integration package.
  • Added 1 data stream ( logout_rest )
  • Added data collection logic.
  • Added the ingest pipelines.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added system test cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/salesforce directory.
  • Run the following command to run tests.

elastic-package test

image

@yug-rajani yug-rajani requested review from lalit-satapathy and a team September 27, 2022 13:15
@yug-rajani yug-rajani self-assigned this Sep 27, 2022
@yug-rajani yug-rajani added enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team Integration:salesforce Salesforce labels Sep 27, 2022
@yug-rajani yug-rajani linked an issue Sep 27, 2022 that may be closed by this pull request
8 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-15T17:36:59.898+0000

  • Duration: 15 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (26/26) 💚 13.636
Lines 96.404% (429/445) 👍 8.849
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic
Copy link

botelastic bot commented Nov 16, 2022

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 16, 2022
@botelastic botelastic bot removed the Stalled label Dec 6, 2022
@kush-elastic kush-elastic marked this pull request as ready for review December 6, 2022 12:13
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider changing the title of the panel as

Top 10 IP address by Logout request count

@kush-elastic
Copy link
Collaborator

by Logout request count

Please also consider changing the title of the panel as

Top 10 IP address by Logout request count

-> We have currently Top 10 IP addresses by request count as the entire dashboard shows the Logout data, Do you still suggest to get this updated ? The only idea of not adding Logout in the name is that the dashboard shows only Logout data.

@kush-elastic
Copy link
Collaborator

@agithomas We have followed this official documentation from Salesforce for all the fields descriptions. We have attached same link in README.md Please have a look over this once.

@agithomas
Copy link
Contributor

@agithomas We have followed this official documentation from Salesforce for all the fields descriptions. We have attached same link in README.md Please have a look over this once.

Some of the suggestions are correct from Elastic's documentation perspective. If you find any suggestions conflicting, please point out.

@agithomas
Copy link
Contributor

We have currently Top 10 IP addresses by request count as the entire dashboard shows the Logout data, Do you still suggest to get this updated ? The only idea of not adding Logout in the name is that the dashboard shows only Logout data.

Yes, please

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend to include a Geo Map similar to login_rest datastream to indicate the logout geo locations making use of the geo lat & lon fields

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic kush-elastic merged commit 5ec6796 into elastic:main Dec 19, 2022
@elasticmachine
Copy link

Package salesforce - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:salesforce Salesforce Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create package for Salesforce integration
5 participants