-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adding multiple processors in cloudfront logs and syslog #4437
Conversation
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
ec2_logs |
50000 | 27777.78 | -22222.22 (-44.44%) | 💔 |
elb_logs |
5555.56 | 4081.63 | -1473.93 (-26.53%) | 💔 |
route53_public_logs |
12820.51 | 7407.41 | -5413.1 (-42.22%) | 💔 |
route53_resolver_logs |
6896.55 | 5347.59 | -1548.96 (-22.46%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
@elasticsatch Thanks for the suggestion. I also added a default processor (commented out) as an example. Please see the last screenshot in PR description. This should help hopefully! |
@kaiyan-sheng Awesome! The change looks all good to me. Thanks for your prompt actions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR is to fix #4395 and #4396 by considering adding multiple processors instead of only one...
Checklist
changelog.yml
file.Screenshots
With this PR, adding processors should look like this:
![Screen Shot 2022-10-11 at 10 28 03 AM](https://user-images.githubusercontent.com/14081635/195148232-8a792285-27f8-4b1a-86a1-235cbff639a4.png)
or you can add an empty line in between processors:
![Screen Shot 2022-10-11 at 10 28 12 AM](https://user-images.githubusercontent.com/14081635/195148308-e0bb208c-6af5-44ef-891f-14083356fa38.png)
The new agent policy looks like this:
and when there is no processor added, here is the agent policy:
For syslog, I tested with the same processors and here is what the agent policy looks like:
This PR also added a default pro
![Screen Shot 2022-10-11 at 2 40 26 PM](https://user-images.githubusercontent.com/14081635/195195638-4c6d28ed-bb0a-4979-bc71-8287d989e7ff.png)
cessor as an example: