Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting rid of internal links #4470

Merged
merged 4 commits into from
Oct 18, 2022
Merged

getting rid of internal links #4470

merged 4 commits into from
Oct 18, 2022

Conversation

tinnytintin10
Copy link
Contributor

this PR removed the internal links in the readme of the CSP integration that doesn't work when viewing the integration in kibana

@elasticmachine
Copy link

elasticmachine commented Oct 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-18T16:25:04.742+0000

  • Duration: 14 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.492
Classes 100.0% (0/0) 💚 2.492
Methods 25.0% (1/4) 👎 -65.345
Lines 100.0% (0/0) 💚 8.442
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@olegsu olegsu merged commit ff38bf7 into main Oct 18, 2022
@oren-zohar oren-zohar deleted the csp_readme_updates branch October 18, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants