Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS - Update ingest pipeline to process event.duration #4481

Merged
merged 2 commits into from Oct 26, 2022

Conversation

muthu-mps
Copy link
Contributor

  • Bug

What does this PR do?

This PR updates the field name in the ingest pipeline processor. Which will ingest the event.duration field to Elasticsearch.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run pipeline tests
Verify the event.duration field is captured in the Expected json file.
Run the integration and verify the data is getting ingested into Elasticsearch.

Related issues

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-20T10:27:32.960+0000

  • Duration: 13 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.508
Classes 100.0% (2/2) 💚 2.508
Methods 85.714% (30/35) 👎 -4.598
Lines 93.772% (271/289) 👍 1.421
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps self-assigned this Oct 20, 2022
@muthu-mps muthu-mps marked this pull request as ready for review October 20, 2022 10:56
@muthu-mps muthu-mps requested a review from a team as a code owner October 20, 2022 10:56
@ManojS-shetty ManojS-shetty self-requested a review October 20, 2022 12:25
Copy link
Contributor

@ManojS-shetty ManojS-shetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muthu-mps muthu-mps merged commit f49bcb7 into elastic:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIS event.duration(time_taken) is ignored in ingest pipeline
3 participants