-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Posture] Remove runtime_cfg var #4496
Conversation
# Conflicts: # packages/cloud_security_posture/changelog.yml # packages/cloud_security_posture/manifest.yml
@@ -11,7 +11,7 @@ categories: | |||
- kubernetes | |||
- security | |||
conditions: | |||
kibana.version: "^8.5.0" | |||
kibana.version: "^8.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
🌐 Coverage report
|
runtimeCfg: | ||
activated_rules: | ||
cis_eks: | ||
- cis_3_1_4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong but I think you're missing indentation here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also works this way, but I'll change the indentation to be aligned with the original format
activated_rules: | ||
cis_eks: | ||
- cis_3_1_4 | ||
- cis_5_4_5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind sorting all the rules? it could be really helpful for scanning the list
@@ -11,7 +11,7 @@ categories: | |||
- kubernetes | |||
- security | |||
conditions: | |||
kibana.version: "^8.5.0" | |||
kibana.version: "^8.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the declaration of runtimeCfg
- otherwise it will still be present in the UI
I am not sure that I understand what you meant. |
Did you check it doesn't appear in the fleet UI? while editing/adding kspm integration |
{{runtimeCfg}} | ||
{{/if}} | ||
|
||
runtimeCfg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at cloudbeat tests I believe the key is runtime_cfg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, I only caught it when I run the E2E test
Finish working on this one - it is blocked until we will deal with the forward-compatible mechanism |
It's more a deprecation of a feature, not changes in the structure, right? |
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.0.6" | |||
changes: | |||
- description: Removing the rule data yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- description: Removing the rule data yaml | |
- description: Removed `runtime_cfg` variable |
/test |
What does this PR do?
The following PR removes the usage of runtime_cfg and moves the configuration to be generated per kubernetes deployment using the hbs files
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues