Extract "Ingress Controller" to a separate integration #451
Conversation
mtojek
added
enhancement
|
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
|
||
| The `access` data stream collects the Nginx Ingress Controller access logs. | ||
|
|
||
| {{fields "access"}} |
There was a problem hiding this comment.
Sample events will not be added?
There was a problem hiding this comment.
Right I forgot about it!
| title: Nginx ingress controller logs | ||
| description: Collect Nginx ingress controller logs | ||
| title: Nginx Ingress Controller access logs | ||
| description: Collect Nginx Ingress Controller access logs |
There was a problem hiding this comment.
Just to note that error logs will not be parsed (these error logs are actually typical golang error logs). We need to track it down somehow since it was part of the migration assessment for this package.
There was a problem hiding this comment.
Hm.. not sure if I understand the part about Golang errors. Could you please elaborate more? Are there any specific nginx ingress controllers Go errors dumped in Beats?
There was a problem hiding this comment.
Ingress Nginx will log errors like any other golang application. There have been requests from users to handle them as well. Unfortunately it seems it was skipped from the migration assessment. or I cannot find it.
There was a problem hiding this comment.
Added an action item to #373 (comment) .
I will add support for error logs in the follow up issue.
|
/test |
|
jenkins run the tests please |
1 similar comment
|
jenkins run the tests please |
* Copy nginx_ingress_controller from nginx * Adjust ingress controller * Extract Nginx Ingress Controller from nginx * Fix: typo * Dump ingress controller logs * Remove Ingress Controller from Nginx * Adjust tests * Docker changes * Docker for system tests * Fix: missing fields * Adjust dashboards * Fix: missing IP address * Adjust screenshots * Add missing sample event
What does this PR do?
This PR extracts
ingress_controllerfrom thenginxto a separate integration.Checklist
How to test this PR locally
Run system tests with defer cleanup option:
elastic-package test system -v --defer-cleanup=120s,navigate to dashboards to see access logs.
Related issues
Screenshots