Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Infoblox nios timezone fix #4540

Merged
merged 10 commits into from
Nov 2, 2022

Conversation

WildDogOne
Copy link
Contributor

@WildDogOne WildDogOne commented Nov 2, 2022

What does this PR do?

There is a small issue in the timezone handling, it doesn't seem to work for all fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Timezone in DHCP Logs Checked
  • Timezone in DNS Logs Checked

@elasticmachine
Copy link

elasticmachine commented Nov 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T21:05:46.523+0000

  • Duration: 16 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@WildDogOne WildDogOne marked this pull request as ready for review November 2, 2022 20:56
@WildDogOne WildDogOne requested a review from a team as a code owner November 2, 2022 20:56
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
Copy link
Contributor

efd6 commented Nov 2, 2022

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.483
Classes 100.0% (4/4) 💚 2.483
Methods 100.0% (40/40) 💚 9.113
Lines 93.578% (612/654) 👍 1.999
Conditionals 100.0% (0/0) 💚

1 similar comment
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚 2.483
Classes 100.0% (4/4) 💚 2.483
Methods 100.0% (40/40) 💚 9.113
Lines 93.578% (612/654) 👍 1.999
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 09ecc36 into elastic:main Nov 2, 2022
@WildDogOne WildDogOne deleted the infoblox-nios-timezone branch November 2, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants