Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing x-pack referneces and updating default values of variables #4545

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Nov 3, 2022

What does this PR do?

Small documentation updates. Removing x-pack references and updating default values of variables

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@gizas gizas requested a review from a team as a code owner November 3, 2022 08:13
@gizas gizas self-assigned this Nov 3, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-03T08:14:37.554+0000

  • Duration: 16 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 88.889% (8/9)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!

@gizas gizas merged commit ddcda48 into main Nov 3, 2022
@gizas gizas deleted the fixcpack branch November 3, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants