Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winlog: allow users to configure providers list #4553

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 4, 2022

What does this PR do?

This adds the capacity for users to configure the providers list available in Winlogbeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screen Shot 2022-11-04 at 12 28 20

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-04T09:56:01.749+0000

  • Duration: 13 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.504
Classes 100.0% (0/0) 💚 2.504
Methods 66.667% (2/3) 👎 -24.174
Lines 100.0% (0/0) 💚 8.052
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 4, 2022 02:19
@efd6 efd6 requested a review from a team as a code owner November 4, 2022 02:19
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 3752c77 into elastic:main Nov 7, 2022
@nicpenning
Copy link
Contributor

👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Windows] Event ID Parameter
4 participants