Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old fields from ec2 fields.yml doc #4567

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

These fields are deprecated in Beats and removed a while ago. This PR is to update the documentation to remove the old fields.

Related issues

@kaiyan-sheng kaiyan-sheng self-assigned this Nov 4, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-08T20:26:52.736+0000

  • Duration: 41 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 2
Total 164

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2022

🚀 Benchmarks report

Package aws 👍(10) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
waf 4950.5 4098.36 -852.14 (-17.21%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (13/13) 💚
Files 92.857% (13/14) 👎 -4.821
Classes 92.857% (13/14) 👎 -4.821
Methods 84.232% (203/241) 👎 -6.795
Lines 95.697% (5204/5438) 👍 4.006
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review November 7, 2022 19:40
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner November 7, 2022 19:40
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Remove deprecated fields from documentation
3 participants