-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] [Jamf Compliance Reporter] Make enhancement in connector with best practices implementation #4574
[Enhancement] [Jamf Compliance Reporter] Make enhancement in connector with best practices implementation #4574
Conversation
…essor to the convert and date processors
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
1123.6 | 814.33 | -309.27 (-27.52%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
@@ -1,30 +1,35 @@ | |||
# newer versions go on top | |||
- version: "0.3.0" | |||
- version: '0.3.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.0
changes: | ||
- description: Update package to ECS 8.5.0. | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/4285 | ||
- version: "0.2.1" | ||
- version: '0.2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double instead of single quotes
ignore_failure: true | ||
- convert: | ||
field: json.header.event_modifier | ||
target_field: jamf_compliance_reporter.log.header.event_modifier | ||
type: string | ||
ignore_missing: true | ||
ignore_failure: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not directly related to this PR, do you mind also removing the ignore_failure
?
@@ -1,7 +1,7 @@ | |||
format_version: 1.0.0 | |||
name: jamf_compliance_reporter | |||
title: Jamf Compliance Reporter | |||
version: "0.3.0" | |||
version: 0.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.4.0
Type of change
What does this PR do?
Make enhancement in Jamf Compliance Reporter connector with listed best practices.
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots