Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Consolidate Shield Events (#4464) Rebased (#4562) squashed #4578

Merged

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Nov 7, 2022

This PR squashes changes from the rebase (#4562) of the Box Consolidate Shield Events (#4464)

  • check changes limited to scope of box_events package
  • re-run test suite
  • connect to target data source and ingest data
  • validate dashboards

djptek and others added 3 commits November 7, 2022 17:20
Commits picked from elastic#4464 - consolidate 4 shield data streams to 1

Co-Authored-By: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…based' into djptek-box_consolidate_shield_events_rebased
@djptek
Copy link
Contributor Author

djptek commented Nov 7, 2022

check changes limited to scope of box_events package

Screenshot 2022-11-07 at 17 40 39

OK

@djptek
Copy link
Contributor Author

djptek commented Nov 7, 2022

re-run test suite

% elastic-package test                                                              (box_consolidate_shield_events_pick)integrations
Run test suite for the package
Run system tests for the package
2022/11/07 17:40:33  INFO Write container logs to file: /Users/djptek/github/integrations/build/container-logs/box-http-1667839233088260000.log
--- Test results for package: box_events - START ---
╭────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE    │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ box_events │ events      │ system    │ httpjson  │ PASS   │ 30.013960742s │
╰────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: box_events - END   ---
Done
Run asset tests for the package
--- Test results for package: box_events - START ---
╭────────────┬─────────────┬───────────┬─────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE    │ DATA STREAM │ TEST TYPE │ TEST NAME                                                           │ RESULT │ TIME ELAPSED │
├────────────┼─────────────┼───────────┼─────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ box_events │             │ asset     │ dashboard box_events-ce6fbf50-2df9-11ed-8003-6d5721603181 is loaded │ PASS   │        823ns │
│ box_events │             │ asset     │ dashboard box_events-ff3d9940-2e03-11ed-8003-6d5721603181 is loaded │ PASS   │        119ns │
│ box_events │ events      │ asset     │ index_template logs-box_events.events is loaded                     │ PASS   │        194ns │
│ box_events │ events      │ asset     │ ingest_pipeline logs-box_events.events-0.3.0 is loaded              │ PASS   │        173ns │
╰────────────┴─────────────┴───────────┴─────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: box_events - END   ---
Done
Run pipeline tests for the package
--- Test results for package: box_events - START ---
╭────────────┬─────────────┬───────────┬───────────────────────────────┬────────┬──────────────╮
│ PACKAGE    │ DATA STREAM │ TEST TYPE │ TEST NAME                     │ RESULT │ TIME ELAPSED │
├────────────┼─────────────┼───────────┼───────────────────────────────┼────────┼──────────────┤
│ box_events │ events      │ pipeline  │ test-anomalous-download.log   │ PASS   │  14.811003ms │
│ box_events │ events      │ pipeline  │ test-copy.log                 │ PASS   │   7.655861ms │
│ box_events │ events      │ pipeline  │ test-create.log               │ PASS   │    5.00129ms │
│ box_events │ events      │ pipeline  │ test-download.log             │ PASS   │   5.663527ms │
│ box_events │ events      │ pipeline  │ test-event-types.log          │ PASS   │  78.028062ms │
│ box_events │ events      │ pipeline  │ test-malicious-content.log    │ PASS   │  22.709285ms │
│ box_events │ events      │ pipeline  │ test-preview.log              │ PASS   │   5.726704ms │
│ box_events │ events      │ pipeline  │ test-rename.log               │ PASS   │   7.466513ms │
│ box_events │ events      │ pipeline  │ test-suspicious-locations.log │ PASS   │  16.128386ms │
│ box_events │ events      │ pipeline  │ test-suspicious-sessions.log  │ PASS   │   8.627854ms │
│ box_events │ events      │ pipeline  │ test-trash.log                │ PASS   │   5.983108ms │
│ box_events │ events      │ pipeline  │ test-upload.log               │ PASS   │    6.16515ms │
╰────────────┴─────────────┴───────────┴───────────────────────────────┴────────┴──────────────╯
--- Test results for package: box_events - END   ---
Done
Run static tests for the package
--- Test results for package: box_events - START ---
╭────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE    │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ box_events │ events      │ static    │ Verify sample_event.json │ PASS   │  53.495691ms │
╰────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: box_events - END   ---
Done

OK

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-07T16:54:47.459+0000

  • Duration: 15 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 7, 2022

🚀 Benchmarks report

Package box_events 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 3412.97 1964.64 -1448.33 (-42.44%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.29
Classes 100.0% (1/1) 💚 2.29
Methods 100.0% (13/13) 💚 8.465
Lines 99.452% (908/913) 👍 7.992
Conditionals 100.0% (0/0) 💚

@djptek
Copy link
Contributor Author

djptek commented Nov 7, 2022

connect to target data source and ingest data

Screenshot 2022-11-07 at 17 56 20

OK

@djptek
Copy link
Contributor Author

djptek commented Nov 7, 2022

validate dashboards

Events (non-shield)

Screenshot 2022-11-07 at 17 49 28

Shield events

Screenshot 2022-11-07 at 17 58 54

Events OK; Saw non-alert events showing up on Shield Dashboard (BUG) so added a filter

{
  "query": {
    "match_phrase": {
      "event.kind": "alert"
    }
  }
}

@djptek djptek marked this pull request as ready for review November 7, 2022 17:16
@djptek djptek requested a review from a team as a code owner November 7, 2022 17:16
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@djptek djptek merged commit ab75b92 into elastic:main Nov 8, 2022
@djptek djptek deleted the box_consolidate_shield_events_pick branch November 8, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants