Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

juniper_*,m365_defender,microsoft_defender_endpoint,mimecast,modsecurity: remove duplicate fields #4611

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 10, 2022

What does this PR do?

This removes duplicate field definitions from juniper_junos, juniper_netscreen, juniper_srx, m365_defender, microsoft_defender_endpoint, mimecast and modsecurity.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 10, 2022

🚀 Benchmarks report

Package microsoft_defender_endpoint 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2754.82 1890.36 -864.46 (-31.38%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-10T03:38:33.206+0000

  • Duration: 20 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 123
Skipped 0
Total 123

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 10, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 100.0% (23/23) 💚 2.083
Classes 100.0% (23/23) 💚 2.083
Methods 94.118% (240/255) 👍 2.815
Lines 84.802% (5641/6652) 👎 -5.894
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 10, 2022 04:47
@efd6 efd6 requested a review from a team as a code owner November 10, 2022 04:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 added the bug Something isn't working label Nov 14, 2022
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit e23f14f into elastic:main Nov 29, 2022
@elasticmachine
Copy link

Package juniper_junos - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=juniper_junos

@elasticmachine
Copy link

Package juniper_netscreen - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=juniper_netscreen

@elasticmachine
Copy link

Package juniper_srx - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx

@elasticmachine
Copy link

Package m365_defender - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@elasticmachine
Copy link

Package microsoft_defender_endpoint - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint

@elasticmachine
Copy link

Package mimecast - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=mimecast

@elasticmachine
Copy link

Package modsecurity - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants