Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add Elastic agent integration #462

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Dec 14, 2020

Add a new integration for Elastic Agent

Still in progress

What does this PR do?

Create a new Elastic Agent integration that add a dashboard for agent metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

How to test this PR locally

This PR depends on this PR of the elastic Agent elastic/beats#22793

Related issues

Screenshots

Screen Shot 2020-12-14 at 9 22 47 PM

Screen Shot 2020-12-14 at 9 09 37 AM

@andresrc andresrc added the Team:Fleet Label for the Fleet team label Dec 14, 2020
@elasticmachine
Copy link

elasticmachine commented Dec 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2020-12-15T22:27:59.891+0000

  • Duration: 27 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

@elasticmachine
Copy link

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor

ph commented Dec 15, 2020

@ravikesarwani Can you take a look?

@nchaulet I am curious, the values looks weirds to me, the graph looks too perfect for me? Are the values aggregated?

@nchaulet
Copy link
Member Author

@ph The graph are stacked per process, what does seems weird to you in the graph?

@ph
Copy link
Contributor

ph commented Dec 15, 2020

what is the left axis for the graph?

@ph ph assigned ruflin and unassigned ruflin Dec 15, 2020
@ph ph requested a review from ruflin December 15, 2020 14:48
@nchaulet
Copy link
Member Author

The left axis is a percentage for CPU, memory size for Memory and the number of open handle

Maybe this screenshot makes more sense

Screen Shot 2020-12-15 at 9 45 34 AM

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchaulet The part that makes me suspicious is that memory usage of all process is identical. My guess is, that it takes memory usage from the parent process, so maybe the reporting is off not the graph. @blakerouse might know more.

I did run and install the package on my end and it works. I suggest we get it in an then iterate on it.

@ravikesarwani
Copy link

Some initial comments from my side:

  • I found this issue that Dimitri created and may help here [Discuss] Dashboard Creation Guidelines #269
  • Can we label the Y axis?
  • Can we add a filter for easy selection by user to select one or more Agent sub processes.
  • For CPU usage and open handles I was thinking if the stacked graph is the best default representation. Line chart maybe more appropriate here. Thoughts?
  • For memory usage stacked maybe good if we can show whole part relationship. Total available memory (8 GB) and Agent, filebeat & metricbeat is taking x, y and z from the total and F is free.
  • We can change the CPU Usage to CPU Usage %
    @nchaulet Feel free to ping me any time for us to chat on Zoom and brainstorm any of the above points.
    Is there some place I can play with this?

@nchaulet
Copy link
Member Author

@ravi-elastic the dashboard as updated in our Zoom conversation

Screen Shot 2020-12-15 at 4 34 53 PM

@nchaulet
Copy link
Member Author

I will merge it as it is and will update in new PRs if we have things to change.

@nchaulet nchaulet merged commit a8f32c7 into elastic:master Dec 16, 2020
@nchaulet nchaulet deleted the feature-add-elastic-agent-integration branch December 16, 2020 00:48
@ph
Copy link
Contributor

ph commented Dec 16, 2020

@nchaulet I've been trying to find a followup issue, did you create one to install this package by default?

@nchaulet
Copy link
Member Author

I just created the follow up issue to install the package by default elastic/kibana#86112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants